Recover Windows helper sync after acknowledged result delivery
This commit is contained in:
@@ -1091,6 +1091,103 @@ fn windows_unconfirmed_helper_head_cannot_replace_a_committed_decision() {
|
||||
);
|
||||
assert!(!reopened.can_start(&f.channel, false, &f.clock));
|
||||
}
|
||||
#[test]
|
||||
fn missed_system_ack_after_result_delivery_requires_archived_definitive_proof() {
|
||||
let mut f = Fixture::new();
|
||||
f.helper_identity = HelperIdentity::System;
|
||||
let mut c = f.client();
|
||||
let mut helper = HelperSnapshot {
|
||||
journal_id: Uuid::new_v4(),
|
||||
checkpoint: 1,
|
||||
previous_decision_id: None,
|
||||
attempts: vec![],
|
||||
};
|
||||
let first = c
|
||||
.prepare(
|
||||
&mut f.db,
|
||||
&f.ledger,
|
||||
f.channel.clone(),
|
||||
Some(&helper),
|
||||
&f.clock,
|
||||
)
|
||||
.unwrap();
|
||||
let anchor = f.decision(&first, true);
|
||||
f.apply(&mut c, &anchor).unwrap();
|
||||
c.apply_consumption(&mut f.ledger, &f.clock).unwrap();
|
||||
helper.previous_decision_id = Some(anchor.decision_id);
|
||||
c.confirm_helper(&helper).unwrap();
|
||||
helper.checkpoint += 1;
|
||||
let (offer, grant, report) = f.add("unknown", true, Some(success()), script());
|
||||
let mut prior = report.unwrap();
|
||||
let Some(Payload::JobResult(result)) = &mut prior.payload else {
|
||||
unreachable!()
|
||||
};
|
||||
result.state = "unknown".into();
|
||||
f.db.execute(
|
||||
"UPDATE job_events SET payload=?1 WHERE id=?2",
|
||||
params![prior.encode_to_vec(), prior.message_id],
|
||||
)
|
||||
.unwrap();
|
||||
let final_report =
|
||||
persist_original_fixture_result(&mut f, &offer, &grant.unwrap(), completion_outcome());
|
||||
let edge = c
|
||||
.prepare(
|
||||
&mut f.db,
|
||||
&f.ledger,
|
||||
f.channel.clone(),
|
||||
Some(&helper),
|
||||
&f.clock,
|
||||
)
|
||||
.unwrap();
|
||||
assert_eq!(edge.request.durable_message_ids.len(), 2);
|
||||
let mut signed = f.decision(&edge, true);
|
||||
signed
|
||||
.acknowledged_message_ids
|
||||
.push(Uuid::parse_str(&final_report.message_id).unwrap());
|
||||
f.apply(&mut c, &signed).unwrap();
|
||||
c.apply_consumption(&mut f.ledger, &f.clock).unwrap();
|
||||
helper.checkpoint += 1;
|
||||
f.channel.connection_generation += 1;
|
||||
let mut fresh = f.client();
|
||||
let prepare = |c: &mut ClientSync, f: &mut Fixture| {
|
||||
c.prepare_with_closed_control_idle(
|
||||
&mut f.db,
|
||||
&f.ledger,
|
||||
f.channel.clone(),
|
||||
Some(&helper),
|
||||
&f.clock,
|
||||
true,
|
||||
)
|
||||
};
|
||||
assert!(prepare(&mut fresh, &mut f).is_err()); // prior report still pending
|
||||
rmm_agent_core::jobs::ack(&mut f.db, &prior.message_id).unwrap();
|
||||
let mut conflicting = prior.clone();
|
||||
if let Some(Payload::JobResult(r)) = &mut conflicting.payload {
|
||||
r.state = "failed".into();
|
||||
}
|
||||
f.db.execute(
|
||||
"UPDATE reconcile_results SET envelope=?1 WHERE id=?2",
|
||||
params![conflicting.encode_to_vec(), prior.message_id],
|
||||
)
|
||||
.unwrap();
|
||||
assert!(prepare(&mut fresh, &mut f).is_err());
|
||||
f.db.execute(
|
||||
"UPDATE reconcile_results SET envelope=?1 WHERE id=?2",
|
||||
params![prior.encode_to_vec(), prior.message_id],
|
||||
)
|
||||
.unwrap();
|
||||
let next = prepare(&mut fresh, &mut f).unwrap();
|
||||
assert_eq!(
|
||||
next.request.previous_decision_id,
|
||||
signed.decision_id.to_string()
|
||||
);
|
||||
assert_eq!(
|
||||
next.request.helper_previous_decision_id,
|
||||
anchor.decision_id.to_string()
|
||||
);
|
||||
assert!(!fresh.can_start(&f.channel, true, &f.clock));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn independent_helper_checkpoint_regression_is_sticky() {
|
||||
let mut f = Fixture::new();
|
||||
|
||||
Reference in New Issue
Block a user