Bind Windows maintenance permission to update template and device identity probe

This commit is contained in:
2026-11-17 16:34:17 +01:00
parent 5c3f5b6a11
commit a799272d91
3 changed files with 68 additions and 12 deletions
+27 -1
View File
@@ -185,7 +185,8 @@ impl SystemScope {
v.contains(
&rmm_domain::jobs::PrivilegedScriptProfile::FullMaintenanceV1,
)
}) || (self.windows_update_max_runtime_seconds.is_some() && job.action.is_windows_update_template()))
}) || (self.windows_update_max_runtime_seconds.is_some()
&& job.action.windows_update_or_identity_probe()))
&& job.action.validate()
&& job
.action
@@ -595,6 +596,31 @@ mod tests {
assert!(!policy.permits("selected", &job, &caps, Utc::now()));
}
#[test]
fn windows_update_window_accepts_only_the_two_fixed_scripts() {
use rmm_domain::jobs::{PrivilegedScriptProfile, WindowsExecutionProfile, WINDOWS_UPDATE_IDENTITY_PROBE, WINDOWS_UPDATE_LONG_CAPABILITY, WINDOWS_UPDATE_SCRIPT_UTF8};
let (mut policy, mut job, mut caps) = fixture();
policy.schema_version = 3;
let scope = &mut policy.scopes[0];
scope.allowed_services.clear();
scope.windows_update_max_runtime_seconds = Some(3600);
caps.extend(["run_script", "system:run_script", "script.powershell/1", "script.powershell.process_remote_signed/1", WINDOWS_UPDATE_LONG_CAPABILITY].map(str::to_owned));
for (script, seconds, expected) in [
(WINDOWS_UPDATE_SCRIPT_UTF8, 3600, true),
(WINDOWS_UPDATE_IDENTITY_PROBE, 30, true),
(WINDOWS_UPDATE_IDENTITY_PROBE, 31, false),
("Write-Output 12", 30, false),
] {
job.action = Action::RunScript {
interpreter:"powershell".into(), script_utf8:script.into(),
arguments:vec![], expected_stdout:None,
windows_execution_profile:Some(WindowsExecutionProfile::PowerShell51RemoteSigned),
privileged_script_profile:Some(PrivilegedScriptProfile::FullMaintenanceV1),
};
job.max_runtime_seconds = seconds;
assert_eq!(policy.permits("selected", &job, &caps, Utc::now()), expected);
}
}
#[test]
fn narrow_scm_ceiling_denies_unreviewed_effects_and_provider_inputs() {
let (mut policy, mut job, caps) = fixture();
let now = Utc::now();