Plan OPNsense POSIX root scripts with explicit device policy, profile and approval
This commit is contained in:
@@ -488,6 +488,11 @@ impl Action {
|
||||
if interpreter == "posix_sh" && script_utf8 == "uname -s\n"
|
||||
&& arguments.is_empty() && expected == "FreeBSD\n")
|
||||
}
|
||||
pub fn opnsense_root_script(&self) -> bool {
|
||||
matches!(self, Self::RunScript {interpreter, windows_execution_profile:None,
|
||||
privileged_script_profile:Some(PrivilegedScriptProfile::FullMaintenanceV1), ..}
|
||||
if interpreter=="posix_sh") && self.validate()
|
||||
}
|
||||
|
||||
/// Shared plan/revalidation/start gate. Passive inventory never implies job support.
|
||||
pub fn available_for(&self, identity: &str, capabilities: &[String]) -> bool {
|
||||
@@ -500,9 +505,10 @@ impl Action {
|
||||
}
|
||||
let has = |cap: &str| capabilities.iter().any(|c| c == cap);
|
||||
if has("opnsense.base/1") {
|
||||
return identity == "agent_service" && has("run_script") && has("rmm.sync.v1")
|
||||
&& has("opnsense.uname/1") && !has("windows.base/1") && !has("linux.base/1")
|
||||
&& self.opnsense_kernel_probe();
|
||||
return has("run_script") && has("rmm.sync.v1") && !has("windows.base/1") && !has("linux.base/1")
|
||||
&& ((identity=="agent_service" && has("opnsense.uname/1") && self.opnsense_kernel_probe())
|
||||
|| (identity=="root" && has("opnsense.root.posix/1") && has(FULL_MAINTENANCE_CAPABILITY)
|
||||
&& has("helper.root.v1") && has("root:run_script") && self.opnsense_root_script()));
|
||||
}
|
||||
if !has(self.name())
|
||||
|| (self.full_maintenance()
|
||||
@@ -858,6 +864,19 @@ mod tests {
|
||||
assert!(!a.available_for("agent_service",&caps));
|
||||
}
|
||||
#[test]
|
||||
fn opnsense_root_requires_full_profile_and_separate_capabilities() {
|
||||
let caps:Vec<_>=["opnsense.base/1","run_script","rmm.sync.v1","opnsense.root.posix/1",
|
||||
FULL_MAINTENANCE_CAPABILITY,"helper.root.v1","root:run_script"].map(str::to_owned).into();
|
||||
let mut a=Action::RunScript{interpreter:"posix_sh".into(),script_utf8:"id -u\n".into(),
|
||||
arguments:vec![],expected_stdout:None,windows_execution_profile:None,
|
||||
privileged_script_profile:Some(PrivilegedScriptProfile::FullMaintenanceV1)};
|
||||
assert!(a.available_for("root",&caps));
|
||||
for omitted in &caps { assert!(!a.available_for("root",&caps.iter().filter(|x|*x!=omitted).cloned().collect::<Vec<_>>())); }
|
||||
assert!(!a.available_for("agent_service",&caps));
|
||||
if let Action::RunScript{interpreter,..}=&mut a { *interpreter="bash".into(); }
|
||||
assert!(!a.available_for("root",&caps));
|
||||
}
|
||||
#[test]
|
||||
fn windows_update_final_report_and_policy_are_exact() {
|
||||
assert_eq!(
|
||||
windows_update_reboot_report(
|
||||
|
||||
@@ -441,7 +441,7 @@ pub(crate) async fn plan_resolved(
|
||||
let row = &rows[0];
|
||||
let caps = capabilities(row.get("capabilities"))?;
|
||||
let action = target_action(&input, &caps)?;
|
||||
if caps.iter().any(|s| s=="opnsense.base/1") &&
|
||||
if input.execution_identity=="agent_service" && caps.iter().any(|s| s=="opnsense.base/1") &&
|
||||
(input.max_runtime_seconds != 10 || input.max_output_bytes != 1024) {
|
||||
return Err(fail("UNSUPPORTED_CAPABILITY"));
|
||||
}
|
||||
|
||||
@@ -16,6 +16,8 @@ use uuid::Uuid;
|
||||
struct Policy {
|
||||
schema_version: u8,
|
||||
linux: Vec<RootScope>,
|
||||
#[serde(default)]
|
||||
opnsense: Vec<RootScope>,
|
||||
windows: Vec<SystemScope>,
|
||||
#[serde(default)]
|
||||
release_anchors: Vec<ReleaseAnchor>,
|
||||
@@ -123,6 +125,8 @@ impl Policy {
|
||||
return false;
|
||||
}
|
||||
let permits_subject = |subject: &str| match job.execution_identity.as_str() {
|
||||
"root" if caps.iter().any(|c| c=="opnsense.base/1") => self.opnsense.iter()
|
||||
.any(|scope| scope.permits(subject,job,caps,None)),
|
||||
"root" => self
|
||||
.linux
|
||||
.iter()
|
||||
@@ -206,7 +210,7 @@ pub(crate) async fn permits(
|
||||
.map_err(|_| invalid())?;
|
||||
let policy: Policy = serde_json::from_slice(&bytes).map_err(|_| invalid())?;
|
||||
if policy.schema_version != 1
|
||||
|| policy.linux.len() + policy.windows.len() > 64
|
||||
|| policy.linux.len() + policy.windows.len() + policy.opnsense.len() > 64
|
||||
|| policy.release_anchors.len() > 64
|
||||
|| policy
|
||||
.release_anchors
|
||||
|
||||
@@ -380,6 +380,9 @@ pub async fn authorize(
|
||||
if crate::managed_scripts::permits(tx, principal, job, &caps).await? {
|
||||
return Ok(());
|
||||
}
|
||||
if caps.iter().any(|c| c=="opnsense.base/1") {
|
||||
return Err(Error(StatusCode::FORBIDDEN,"SCRIPT_HELPER_SCOPE_DENIED"));
|
||||
}
|
||||
let policy = load()?;
|
||||
let global_log_units = if matches!(job.action, Action::QueryLogs { .. }) {
|
||||
parse_log_units(std::env::var("RMM_ROOT_LOG_UNITS").ok().as_deref())?
|
||||
|
||||
Reference in New Issue
Block a user