From 6bf6e2539ccd5b46141e9a0f0d4058c1ce5ee367 Mon Sep 17 00:00:00 2001 From: Kevin Janssen Date: Thu, 19 Nov 2026 20:10:36 +0100 Subject: [PATCH] Exercise appliance secret projection, truncation and device-only UI states --- deploy/opnsense/collect.py | 4 ++-- deploy/opnsense/test_collect.py | 28 ++++++++++++++++++++++++++++ web/src/opnsense.test.tsx | 24 ++++++++++++++++++++++++ 3 files changed, 54 insertions(+), 2 deletions(-) create mode 100644 deploy/opnsense/test_collect.py create mode 100644 web/src/opnsense.test.tsx diff --git a/deploy/opnsense/collect.py b/deploy/opnsense/collect.py index f087c16..dff9998 100644 --- a/deploy/opnsense/collect.py +++ b/deploy/opnsense/collect.py @@ -49,9 +49,9 @@ def rows(provider): return dict(status='partial' if partial else 'ok', entries=entries) -def configured(): +def configured(config_path='/conf/config.xml'): # Project only these model paths and display fields. Never serialize XML. - with open('/conf/config.xml', 'rb') as f: + with open(config_path, 'rb') as f: data = f.read(8 * 1024 * 1024 + 1) if len(data) > 8 * 1024 * 1024: raise ValueError('config size') diff --git a/deploy/opnsense/test_collect.py b/deploy/opnsense/test_collect.py new file mode 100644 index 0000000..c4cfa57 --- /dev/null +++ b/deploy/opnsense/test_collect.py @@ -0,0 +1,28 @@ +import tempfile +import unittest +from pathlib import Path +import collect + + +class ApplianceProjection(unittest.TestCase): + def test_configured_disabled_is_not_a_connection_and_secrets_stay_local(self): + with tempfile.TemporaryDirectory() as root: + p = Path(root)/'config.xml' + p.write_text('' + 'Test0do-not-export' + '' + '1Labdo-not-export' + '') + self.assertEqual(collect.rows(lambda:collect.configured(p)), { + 'status':'ok','entries':['WireGuard-Instanz · Test · deaktiviert','OpenVPN · Lab · aktiviert']}) + p.write_text(' { + const d = { source_id:'opnsense.base', inventory:{ + ipsec:{status:'unavailable',entries:[]}, openvpn:{status:'ok',entries:[]}, + firewall:{status:'partial', entries:['pass in on vtnet0']}, + interfaces:{status:'ok', entries:[{name:'vtnet0',addresses:['192.0.2.1/24']}]}, + software:{status:'ok',entries:[{name:'opnsense',version:'26.7'}]}, + users:{status:'unavailable',entries:[]} + }}; + const view = renderToStaticMarkup(); + expect(view).toMatch(/IPsec[^<]*<\/h3>

Nicht ermittelbar/); + expect(view).toMatch(/OpenVPN[^<]*<\/h3>

Keine Einträge/); + expect(view).toContain('unvollständige Liste'); + expect(view).toContain('pass in on vtnet0'); + expect(renderToStaticMarkup()).toBe(''); + const system = renderToStaticMarkup(); + expect(system).toContain('192.0.2.1/24'); + expect(system).toContain('26.7'); + expect(system).not.toContain('Keine Benutzer angemeldet'); +});